Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make table alias accessible from MySqlDbColumn #1522

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Make table alias accessible from MySqlDbColumn #1522

merged 3 commits into from
Oct 28, 2024
+48 −0

Conversation

AlexKerman
Copy link
Contributor

This PR make table alias accessible in data reader.
Ref #1521

@AlexKerman
Make table alias accessible from MySqlDbColumn

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
Loading
Loading status checks…
02bcc0f 
Signed-off-by: AlexKerman <kerman@ormfactory.com>
@bgrainger
Copy link
Member

Thanks for the contribution! I'll take a look soon. (Mostly just want to see if there's precedent in other ADO.NET providers.)

It would be good to include some tests for this new behaviour.

@bgrainger
Copy link
Member

Npgsql adds a TableOID property: https://github.com/npgsql/npgsql/blob/32eb7097c81e3dc6e3cdc59c2f19592883f00c77/src/Npgsql/Schema/NpgsqlDbColumn.cs#L199-L202

SqlClient doesn't appear to have public DbColumn-derived type.

@bgrainger
Add tests for MySqlDbColumn.TableName.

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
fb239d6 
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
@bgrainger
Add documentation comments for TableName.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
31c0852 
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
@bgrainger bgrainger merged commit e132a64 into mysql-net:master Oct 28, 2024
22 checks passed
@bgrainger
Copy link
Member

Thanks for the contribution!

@bgrainger bgrainger mentioned this pull request Oct 28, 2024
Closed
@bgrainger bgrainger linked an issue Oct 28, 2024 that may be closed by this pull request
Unable to get access to table alias name in data reader #1521
Closed
@AlexKerman
Copy link
Contributor Author

AlexKerman commented Oct 29, 2024 •
edited
Loading

Thanks for the contribution!

Thank you for your research. It very useful for me because I doing postgres support for my tool. Unfortunately I don't know how to test this properly. I had researched test for ProviderType field and didn't found out how to insert test for my field corectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to get access to table alias name in data reader
2 participants
@AlexKerman @bgrainger