Restore implicit hue for wide categorical data #3496
Merged
+58
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the big categorical plot refactor, a default change was made where plots are no longer implicitly color-mapped.
There is a simple path to restoring the previous default behavior (if desired) when using long-form data: add an explicit redundant hue-mapping. e.g.
boxplot(df, x="grp", y="val") -> boxplot(df, x="grp", y="val", hue="grp").But when using wide-form data, there is no equivalent path. So this PR adds some extra backwards-compatibility hacks so that wide-form plots retain the implicit color map. Additionally, wide-form plots can be coerced to a single color by passing
color=. There is some additional special-casing aroundpointplot, which has always been an exception in its default behavior.