Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldflags failed for gofumpt 0.4.0 release #253

Closed
chenrui333 opened this issue Dec 5, 2022 · 4 comments
Closed

ldflags failed for gofumpt 0.4.0 release #253

chenrui333 opened this issue Dec 5, 2022 · 4 comments

Comments

@chenrui333
Copy link

It looks like the ldflags failed for gofumpt 0.4.0 release

How to reproduce

$ ./gofumpt_v0.4.0_darwin_arm64 --version
v0.0.0-20220927090253-6da4e628305e (go1.19.1)

relates to Homebrew/homebrew-core#112189

@mvdan
Copy link
Owner

mvdan commented Dec 5, 2022

Thanks for spotting, that was indeed not intentional. The version has the right commit, it just lacks the semver tag. It's late to swap the existing binaries now, as I don't want to break any users who took their checksums, and a proper fix would require changing the code. But I'll certainly make sure the upcoming release has a proper version.

mvdan added a commit to mvdan/dotfiles that referenced this issue Dec 5, 2022
@mvdan
Copy link
Owner

mvdan commented Dec 5, 2022

See the change above to my release build script.

@chenrui333
Copy link
Author

I think even hardcoded the value in the source code before the release is not a bad idea. Any timeline for the new release?

@mvdan
Copy link
Owner

mvdan commented Dec 13, 2022

Soon. I'm not going to rush it as this doesn't seem like a critical issue.

@mvdan mvdan closed this as completed in d5451f0 Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants