-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Remove needless check in useGridStateInitialization
#14181
Merged
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannager
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Aug 13, 2024
romgrk
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Deploy preview: https://deploy-preview-14181--material-ui-x.netlify.app/ |
@k-rajat19 can you run |
Loading status checks…
…-check
auto-merge was automatically disabled
August 14, 2024 09:08
Head branch was pushed to by a user without write access
Done👍 |
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
oliviertassinari
changed the title
[DataGrid] remove needless check in
[DataGrid] Remove needless check in Oct 1, 2024
useGridStateInitialization
useGridStateInitialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
core
Infrastructure work going on behind the scenes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publishEvent
is always available during grid state initialization (because we are adding it in API synchronously before state initialization) so there is no need to check that.