Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Rename some @mui/material/styles/createTypography exports #45558

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 12, 2025

Rename some interfaces to match the publicly exported ones. @mui/material/styles/createTypography is not exported and these are aliased and publicly exported in @mui/material/styles. this way we can remove the alias, there is no need to have an internal name that is different from the public one.

export {
Typography as TypographyVariants,
TypographyOptions as TypographyVariantsOptions,
TypographyStyle,
Variant as TypographyVariant,
} from './createTypography';

=>

export {
TypographyVariants,
TypographyVariantsOptions,
TypographyStyle,
TypographyVariant,
} from './createTypography';

This is not a breaking change if you're importing from @mui/material/styles, if you're importing from @mui/material/styles/createTheme then it will already break due to the subpath not being exported.

This reverts commit f9d4c22.
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Mar 12, 2025
@mui-bot
Copy link

mui-bot commented Mar 12, 2025

Netlify deploy preview

https://deploy-preview-45558--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a867bfc

@Janpot Janpot marked this pull request as ready for review March 12, 2025 09:34
@Janpot Janpot requested a review from DiegoAndai March 12, 2025 09:34
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Janpot Janpot merged commit fa7123d into mui:master Mar 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants