Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Add @ts-ignore to avoid type checking for MUI X #45555

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 12, 2025

Avoid type error in MUI X repo, see #45371 (comment)

I don't see other ways that using @ts-ignore if still need to support Material UI v5 in MUI X.

Tested with mui/mui-x#16662, the CI (test_types) is green.

Sorry, something went wrong.

@siriwatknp siriwatknp added the scope: docs-infra Specific to the docs-infra product label Mar 12, 2025
@mui-bot
Copy link

mui-bot commented Mar 12, 2025

Netlify deploy preview

https://deploy-preview-45555--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ca0ba91

@siriwatknp siriwatknp marked this pull request as ready for review March 12, 2025 10:27
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. 👌
It looks like it helps to avoid CI problems until we bump to latest material. 👍
mui/mui-x#16662

@siriwatknp siriwatknp enabled auto-merge (squash) March 12, 2025 10:39
@siriwatknp siriwatknp merged commit 02cf529 into mui:master Mar 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants