Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Accordion] Add missing root slot #45532

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 9, 2025

This PR #40418 missed adding root slot, I've added it to make it consistent across components

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sai6855 sai6855 added component: accordion This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Mar 9, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sai6855 sai6855 added the enhancement This is not a bug, nor a new feature label Mar 9, 2025
@mui-bot
Copy link

mui-bot commented Mar 9, 2025

Netlify deploy preview

https://deploy-preview-45532--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 1fa3472

@sai6855 sai6855 marked this pull request as draft March 9, 2025 06:58
sai6855 added 2 commits March 9, 2025 12:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
… into accordion-root
@sai6855 sai6855 changed the title [material-ui][Accordion] Add missing root slot [material-ui][Accordion] Add missing root slot Mar 9, 2025
@sai6855 sai6855 requested review from DiegoAndai and siriwatknp March 9, 2025 12:55
@sai6855 sai6855 marked this pull request as ready for review March 9, 2025 16:36
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@sai6855 sai6855 merged commit 1ab010e into mui:master Mar 10, 2025
22 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v6.x

github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants