-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][Backdrop] Fix component name in migration guide #45506
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sai6855
commented
Mar 7, 2025
•
edited
Loading
edited
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewBundle size report |
sai6855
commented
Mar 7, 2025
@@ -461,7 +461,7 @@ The Backdrop's `componentsProps` prop was deprecated in favor of `slotProps`: | |||
The Backdrop's `TransitionComponent` prop was deprecated in favor of `slots.transition`: | |||
|
|||
```diff | |||
<Slider | |||
<Backdrop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slider
was rendered instead of Backdrop
. This PR fixes the issue.
@sai6855 As said earlier as well, docs related PR should contain [docs] in PR title. And also have "docs" label added. |
ZeeshanTamboli
approved these changes
Mar 7, 2025
Cherry-pick PRs will be created targeting branches: v6.x |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
Loading
Loading status checks…
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: backdrop
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
needs cherry-pick
The PR should be cherry-picked to master after merge
v6.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.