Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][utils] use correct iri-reference homepage format [NOTICKET] #45472

Merged

Conversation

dahiro
Copy link
Contributor

@dahiro dahiro commented Mar 3, 2025

I had the issue that generating an SBOM with https://github.com/CycloneDX/cyclonedx-node-npm#readme created invalid sboms since the homepage had an invalid iri-reference

Do I need to create a PR for the 5.x and 6.x branches as well?

Sorry, something went wrong.

@mui-bot
Copy link

mui-bot commented Mar 3, 2025

Netlify deploy preview

https://deploy-preview-45472--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1373e36

@dahiro dahiro changed the title [docs] use correct iri-reference homepage format [NOTICKET] [material-ui][utils] use correct iri-reference homepage format [NOTICKET] Mar 3, 2025
@zannager zannager added the package: utils Specific to the @mui/utils package label Mar 4, 2025
@zannager zannager requested a review from DiegoAndai March 4, 2025 08:24
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Do I need to create a PR for the 5.x and 6.x branches as well?

We can do one for v6 too, I think we can leave the v5 as is unless people specifically report the problem.

@DiegoAndai DiegoAndai added needs cherry-pick The PR should be cherry-picked to master after merge v6.x labels Mar 7, 2025
@DiegoAndai DiegoAndai merged commit d618bf9 into mui:master Mar 7, 2025
21 checks passed
Copy link

github-actions bot commented Mar 7, 2025

Cherry-pick PRs will be created targeting branches: v6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge package: utils Specific to the @mui/utils package v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants