[material-ui][Box] Add missing component to BoxProps type
#44643
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
typescript
package: material-ui
Netlify deploy previewhttps://deploy-preview-44643--material-ui.netlify.app/ Bundle size report |
Closed
1 task
DiegoAndai
force-pushed
the
fix-box-types
branch
from
4f8944e to
947ab93
Compare
siriwatknp
approved these changes
Dec 4, 2024
sai6855
reviewed
Dec 4, 2024
| @@ -39,3 +39,5 @@ function ColorTest() { | |||
| sx={(theme) => ({ backgroundColor: theme.vars.palette.background.default })} | |||
| />; | |||
| } | |||
|
|
|||
| expectType<SystemBoxProps['component'], MaterialBoxProps['component']>; | |||
There was a problem hiding this comment.
expectType is function know? for e.g, this passes expectType<null,undefined> but this doesn't expectType<null,undefined>()
There was a problem hiding this comment.
In this case I'm using it to check types, so there's no value to be provided.
There was a problem hiding this comment.
From my understanding of expectType, it only works if it is called. So for e.g, typescript doesn't throw error for following code, when ideally it should
expectType<null,undefined>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43955
This was an oversight of #43384, as the System
BoxPropshad thecomponentproperty, but Material UI's didn't. They should be equivalent. I added a test for it as well.