Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: optional tag prefix for monorepo support #178

Closed
jfly opened this issue Apr 28, 2024 · 3 comments
Closed

Feature request: optional tag prefix for monorepo support #178

jfly opened this issue Apr 28, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@jfly
Copy link

jfly commented Apr 28, 2024

First off, thanks for the great tool!

We operate in a monorepo with a tag naming convention like packagename-v1.2.3. Currently, to support this, we need each project to specify a pattern in their [tool.poetry-dynamic-versioning] section, and this is a little finicky (it's a long, scary regex that we have a make a copy of for each project in our monorepo).

Would you be open to a generic setting for this? I'm thinking something like an optional pattern-prefix option that we could set to "packagename-", and then we wouldn't have to set pattern at all.

I'd be happy to send in a PR for this if you're open to it. That said, I also completely understand if this is not a feature you want to support (as I mentioned before, the existing pattern option does work for us, it's just a little finicky).

@mtkennerly
Copy link
Owner

I think pattern-prefix makes sense to add 👍

Once these Dunamai changes are released, we can integrate them in the plugin: mtkennerly/dunamai@f223462

@mtkennerly mtkennerly added this to the v1.3.0 milestone Apr 29, 2024
@jfly
Copy link
Author

jfly commented Apr 29, 2024

Thanks, we really appreciate it!

mtkennerly added a commit that referenced this issue Apr 30, 2024

Verified

This commit was signed with the committer’s verified signature.
mtkennerly Matthew Kennerly
@mtkennerly
Copy link
Owner

No problem :) Dunamai v1.21.0 and poetry-dynamic-versioning v1.3.0 are now available with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants