Wrong version being reported

[Silvanoc]

Using dunamai to obtain the last tag of project LinkML doesn't work correctly on a GitLab pipeline (locally runs as expected, even when using the same container image being used in the pipeline).

I'm letting git tag show me all the tags sorted (--sort) by all the possible keys and the result is always the same (1.5.2.xyz as of now). But when I use dunamai from git to get that version I obtain 1.5.0.xyz 😮.

I've already checked that the tags are annotated and that the initial commit is not tagged and empty.

I can reproduce it, but only in the pipeline, therefore debugging is a bit cumbersome... Any hints on how to diagnose the issue?

[Silvanoc]

The topological ordering of the log is responsible for it. Don't ask me why it's ordering differently on the pipeline than locally (using the same container and therefore the same git version).

[Silvanoc]

I found out something more. A branch that was created from a commit following v1.5.0 (before v1.5.1) has been merged after v1.5.2 and git log --topo-order appears to be taking that branch in the topological order instead of the main one that is being taken on my machine. Why?

It is a shallow clone, if I unshallow it, then it works!

IMO dunamai should report at least a warning (and should be added to the documentation) that due to some issues with git log --topo-order, dunamai might provide unexpected results.

[mtkennerly]

It is a shallow clone, if I unshallow it, then it works!

That can definitely cause unexpected output. For example, Gitlab defaults to a clone depth of 50, so if your last tag was over 50 commits ago, you'd end up with a version base of 0.0.0. I thought this was in the documentation already, but it doesn't seem to be, so I'll add a note.

[Silvanoc]

git rev-parse --is-shallow-repository tells you if it's a shallow repository, dunamai could check it and report a warning.

[mtkennerly]

The next release will include an automatic check:

$ dunamai from git
Warning: This is a shallow repository, so Dunamai may not produce the correct version.
0.0.0.post8.dev0+8e8b1e1

$ echo $?
0

$ dunamai from git --strict
This is a shallow repository, so Dunamai may not produce the correct version.

$ echo $?
1

[Silvanoc]

Will the poetry-dynamic-versioning option strict also result in the same check?

[mtkennerly]

Yes, it will :) poetry-dynamic-versioning will just need an update to show the warning, but the strict error will happen automatically.

[mtkennerly]

Dunamai v1.17.0 and poetry-dynamic-versioning v0.22.0 are out now and include these changes.

[Silvanoc]

It's great how quickly you've addressed it! 💯