Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master branch: ntohs / ntohl undeclared #521

Closed
ThomasWaldmann opened this issue Dec 3, 2022 · 4 comments
Closed

master branch: ntohs / ntohl undeclared #521

ThomasWaldmann opened this issue Dec 3, 2022 · 4 comments

Comments

@ThomasWaldmann
Copy link
Contributor

ThomasWaldmann commented Dec 3, 2022 •
edited

borgbackup/borg#7181 (comment)

See there:

First all the changes from msgpack master were ported to our bundled msgpack in borgbackup 1.1-maint branch.

Then CI was failing. ntohs / ntohl undeclared.

Then the change that removed the include was reverted which made CI happy again.

So I guess you need to revert this change in master branch here also.

Note: the bundled msgpack in borg 1.1-maint is a slightly patched version 0.5.6, see there: https://github.com/borgbackup/borg/blob/e79986b2835291431f04683423304a02b039c0c1/src/borg/algorithms/msgpack/_version.py
@klemensn
Copy link

klemensn commented Dec 3, 2022

As explained here: #513 (comment)

@methane
Copy link
Member

methane commented Dec 4, 2022

See #514

@ThomasWaldmann
Copy link
Contributor Author

Oh, sorry, looks like I missed that. @_@

@ThomasWaldmann
Copy link
Contributor Author

Guess this can be closed. Only thing left to do is to release the fixed msgpack code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@methane @ThomasWaldmann @klemensn