feat: compatible with rspack #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and this is more friendly to monorepo |
sibelius
approved these changes
Jan 24, 2024
alvarogfn
approved these changes
Mar 7, 2024
|
hi @mrsteele sry for ping you, but it seems that this pr is ready for merging. Could you please help merge and release a new version? |
|
Any chance you ran tests? I want to make sure it’s compatible with previous versions of webpack/node. |
|
Didn't notice webpack4 don't have |
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
compiler.webpack.DefinePlugininstead of require from webpack, this is also available way in webpack, and can be compatible with rspack.This can also avoid requiring wrong webpack when using monorepo and have multiple webpack in node_modules