-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect parsing of wrapped values #214
Comments
Thanks for reporting this @pavelhoral and apologies that it wasn't working as anticipated for your use case. I've confirmed I can reproduce this issue. I suspect it's a bug with the CSV string parser logic where something isn't quite getting stored properly. I should have some time to walk through this closer this coming weekend, so I'll keep you posted as to when I have a fix published on NPM. |
As reported in #214, there was a bug with how the CSV parser was handling quoted fields which had newlines (or EOL delimiters) embedded in them. Since the value is wrapped in quotes, the EOL delimiter should not be interpreted as though it's a new line or the start of another field as it previously was. This commit introduces a fix to ensure that quoted fields are parsed properly regardless of whether there is a nested EOL delimiter inside. Fixes #214
Thanks again for reporting this @pavelhoral. I'll be pushing version |
This bug still exists in the latest 4.1.0 version. From this test file I am getting two incomplete rows |
I have created new issue #240 because of no answer |
Hi @symbianm. The bug reported in this issue is not still present in
I will now switch over to #240 to look into the separate issue you're reporting. |
Background Information
master
irrelevant
The issue I'm reporting is with:
I have...
Expected Behavior
Quoted values split across multiple lines should be correctly parsed.
Actual Behavior
The parser behaves incorrectly when the end quote is at the start of a new line.
Data Sample
CSV:
This is being parsed as:
I did try to fix it but the parser makes almost no sense to me so I am creating this issue and going to find another library or write my own parser :). Good luck.
The text was updated successfully, but these errors were encountered: