Enable auto font-size for active forms #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Would you please add a changelog entry and a test with a code example showcasing the new functionality? |
|
Done |
ChrisB9
commented
Sep 17, 2022
| @@ -70,7 +70,7 @@ public function open($attr, &$ahtml, &$ihtml) | |||
| if (isset($properties['FONT-FAMILY'])) { | |||
| $this->mpdf->SetFont($properties['FONT-FAMILY'], $this->mpdf->FontStyle, 0, false); | |||
| } | |||
| if (isset($properties['FONT-SIZE'])) { | |||
| if (isset($properties['FONT-SIZE']) && $properties['FONT-SIZE'] !== 'auto') { | |||
There was a problem hiding this comment.
I wonder, though, whether we should filter out font-size: 0 too, as it breaks the input and text-area as well.
Maybe like this:
0 = default, auto = /F 0
|
This works like a charm. Merging, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #834
According to this commit, it seems to be completely enough to just set the font-size parameter within the AcroForm definition to 0.