Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page number Myanmar language support #1201

Merged
merged 4 commits into from Apr 15, 2020
Merged

Page number Myanmar language support #1201

merged 4 commits into from Apr 15, 2020

Conversation

MinKyawNyunt
Copy link
Contributor

@MinKyawNyunt MinKyawNyunt commented Apr 10, 2020 •
edited

Myanmar Language Support for Page Number.

@MinKyawNyunt MinKyawNyunt changed the title Page number myanmar language Page number Myanmar language Support Apr 10, 2020
@MinKyawNyunt MinKyawNyunt changed the title Page number Myanmar language Support Page number Myanmar language support Apr 10, 2020
@finwe
Copy link
Member

finwe commented Apr 10, 2020

Thanks for the PR. Can you add a unit test with a code sample using your change? See tests/Issues directory in the repo.

@MinKyawNyunt
Copy link
Contributor Author

Done adding unit test.

@finwe finwe merged commit f0a44d9 into mpdf:development Apr 15, 2020
sreenadh pushed a commit to sreenadh/mpdf that referenced this pull request May 10, 2020
@MinKyawNyunt @sreenadh
Page number Myanmar language support (mpdf#1201)
1490b75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/enhancement missing sample / test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MinKyawNyunt @finwe