fix: Remove READ_EXTERNAL_STORAGE permission requirement #3018
Conversation
The READ_EXTERNAL_STORAGE permission is not needed, and actually unavailable on some apps such as RefBrow. This patch removes the check and all supporting implementation.
|
I have locally verified (with Node 21.5.0) that I can launch RefBrow with web-ext with this patch, using the command at #2312 (comment) |
|
I also gave a try to this branch with nodejs 20 and Firefox for Android release, and no surprises with that combination neither, all worked as I was already expecting it to. |
There was a problem hiding this comment.
looks great, I'm so happy that this old workarond was isolated enough to only require no additional changes besides a few removal \o/
Let's ship this!
As we were discussing earlier today this, besides making web-ext able to run the reference browser again, it also reduce friction for all developers targeting android by not requiring to run any manual adb command anymore, which is great!!!
Thanks a lor Rob for taking care of this cleanup.
The READ_EXTERNAL_STORAGE permission is not needed, and actually unavailable on some apps such as RefBrow. This patch removes the check and all supporting implementation.
) (#3023) Co-authored-by: Rob Wu <rob@robwu.nl>
The READ_EXTERNAL_STORAGE permission is not needed, and actually unavailable on some apps such as RefBrow. This patch removes the check and all supporting implementation.
Fixes #2312