Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inputting/searching countries and locales by their codes rather than full names #10495

Open
aminomancer opened this issue Apr 1, 2024 · 0 comments
Labels
Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html

Comments

@aminomancer
Copy link
Member

aminomancer commented Apr 1, 2024

Sometimes we're given a long list of country or language codes, or they might be pulled from a list of supported regions for a feature in source code (example). And since Experimenter requires inputting the full names, you have to spend some time figuring out the corresponding name for each code. Not the end of the world, but still a papercut.

I believe this field is a frontend for adding targeting in the form of language/region codes. If we start from a list of codes and the final output is the same list of codes, then there's no need for the middleman. But I don't propose eliminating the full names, since those are probably used often. I think the field is based on react-select, and it has some kind of fuzzy search algo, so the entries could be like this:

{
  value: "United Kingdom GB",
  label: "United Kingdom"
}

Or the label could include the code too, like United Kingdom (GB). But that is just to show that you don't need to visually display the code to make the entries searchable by code.

┆Issue is synchronized with this Jira Task

@aminomancer aminomancer added the Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html
Projects
None yet
Development

No branches or pull requests

1 participant