Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Checks Bug]: Checks are not being picked up correctly with a space between # and check type #4909

Open
kik-kik opened this issue Jan 29, 2024 · 1 comment

Comments

@kik-kik
Copy link
Contributor

kik-kik commented Jan 29, 2024

What is the issue?

Checks are not being picked up correctly with a space between # and check type.

For example: https://github.com/mozilla/bigquery-etl/blob/1b9750cdfbbc957b7580d83cd48714c19be4c767/sql_generators/glean_usage/templates/baseline_clients_last_seen_v1.checks.sql

What we see in the definition:

# warn
[..]
check_definition
[...]

Expected format:

#warn
[..]
check_definition
[...]

How can we reproduce the bug

No response

┆Issue is synchronized with this Jira Task

@kik-kik
Copy link
Contributor Author

kik-kik commented Jan 29, 2024

This should even be addressed by having a validation process for the checks to ensure valid tags / labels are used for ETL checks.

Or, by also supporting tags / labels that contain a space between # and the ETL check mode (fail / warn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant