Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve logging for bigquery-etl circleCI dry_run_sql #4161

Open
data-sync-user opened this issue Aug 4, 2023 · 1 comment
Open

improve logging for bigquery-etl circleCI dry_run_sql #4161

data-sync-user opened this issue Aug 4, 2023 · 1 comment

Comments

@data-sync-user
Copy link
Collaborator

currently failures are logged by timestamp and a failure might be hidden in between lots and lots of output

to make it easier to see what the problem was it would be nice to collect all errors and print them at the end for better readability

https://app.circleci.com/pipelines/github/mozilla/bigquery-etl/23638/workflows/b67d3464-56c8-4e3c-b530-59d8bd6c9840/jobs/242023 example for failed dry_run_sql

┆Issue is synchronized with this Jira Task
@data-sync-user
Copy link
Collaborator Author

➤ Ben Wu commented:

This is partially implemented with #5771 ( https://github.com/mozilla/bigquery-etl/pull/5771|smart-link )

The list of queries is printed at the end (example ( https://app.circleci.com/pipelines/github/mozilla/bigquery-etl/35759/workflows/bcbf30f2-9039-47b7-844a-9da99bc71182/jobs/401538 )) so it’s easier to search for things. There’s still room for improvement by adding the error messages as well but that will likely take some reorganizing of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@data-sync-user