Enterprise add-ons should be treated as self-hosted add-ons #5344
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
force-pushed
the
fix-enterprise
branch
from
bcf806e to
22cbcaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5344 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 51 51
Lines 2897 2898 +1
Branches 887 888 +1
=======================================
+ Hits 2861 2862 +1
Misses 36 36 ☔ View full report in Codecov by Sentry. |
willdurand
commented
Jun 17, 2024
| @@ -138,7 +142,7 @@ export default class ManifestJSONParser extends JSONParser { | |||
|
|
|||
| this.io = io; | |||
| this.isAlreadySigned = isAlreadySigned; | |||
| this.isEnterpriseAddon = this.schemaValidatorOptions?.enterprise ?? false; | |||
| this.isEnterpriseAddon = isEnterprise; | |||
There was a problem hiding this comment.
I noticed we didn't have to use the schemaValidatorOptions to pass this prop here.
Rob--W
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5345