Remove --scan-file option #5343
Merged
+1
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5343 +/- ##
==========================================
+ Coverage 98.75% 98.78% +0.02%
==========================================
Files 51 51
Lines 2902 2878 -24
Branches 890 876 -14
==========================================
- Hits 2866 2843 -23
+ Misses 36 35 -1 ☔ View full report in Codecov by Sentry. |
rpl
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
@willdurand lgtm. Thanks a lot for taking the time to track down all the changes on implementation and test side that used to only be there for the "not really used" ("not that much officially supported") --scan-file option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda fixes #5319