Introduce a --enterprise flag #5340
Conversation
willdurand
force-pushed
the
enterprise-flag
branch
4 times, most recently
from
45cf20a to
864f407
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5340 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 51 51
Lines 2896 2902 +6
Branches 887 890 +3
=======================================
+ Hits 2860 2866 +6
Misses 36 36 ☔ View full report in Codecov by Sentry. |
willdurand
force-pushed
the
enterprise-flag
branch
from
864f407 to
fb2aca2
Compare
There was a problem hiding this comment.
@willdurand looks pretty good to me, I have just one thought (well, maybe two packed into one :-P) about explicitly state in this new ADMIN_INSTALL_ONLY_REQUIRED linting error where the property is supposed to be set (mainly for when the error is reported for the property being required but not set at all, or set in the wrong part of the manifest).
Marking as request changes to signal this is currently pending on double-checking if that thought is something we should be covering in this PR before merging it.
willdurand
force-pushed
the
enterprise-flag
branch
from
fb2aca2 to
100aa25
Compare
willdurand
force-pushed
the
enterprise-flag
branch
from
100aa25 to
989609a
Compare
| export const ADMIN_INSTALL_ONLY_REQUIRED = { | ||
| code: 'ADMIN_INSTALL_ONLY_REQUIRED', | ||
| message: i18n._(`"/browser_specific_settings/gecko/admin_install_only" | ||
| property must be set to "true"."`), |
There was a problem hiding this comment.
There's an extra " at the end
Fixes #5341
Add a new CLI flag to control the checks for enterprise add-ons.