Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest dropping incognito:"split" when present in manifest.json #5316

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

willdurand
Copy link
Member

Fixes #5261

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (9c02ae8) to head (a01fc90).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5316   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          51       51           
  Lines        2887     2892    +5     
  Branches      885      886    +1     
=======================================
+ Hits         2851     2856    +5     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand willdurand requested a review from rpl May 31, 2024 10:47
Co-authored-by: Rob Wu <rob@robwu.nl>
@willdurand willdurand removed the request for review from rpl June 6, 2024 12:19
@willdurand willdurand merged commit 14a3a87 into master Jun 6, 2024
5 checks passed
@willdurand willdurand deleted the split branch June 6, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest dropping incognito: "split" when present in manifest.json
2 participants