Ignore non-existing Firefox for Android versions (69-78) #5094
+131
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The androidStrictMinVersion method is used to derive the version used to detect incompatibilities in the manifest. Because there haven't been any official Firefox for Android release in the range [69, 78], we should interpret `browser_specific_settings.gecko.strict_min_version` as version 79 when its value is in the range [69, 78].
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5094 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 54 54
Lines 2919 2922 +3
Branches 887 888 +1
=======================================
+ Hits 2882 2885 +3
Misses 37 37
☔ View full report in Codecov by Sentry. |
willdurand
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5093.
Resolves the CI error that prevents #5090 from being merged.
The androidStrictMinVersion method is used to derive the version used to detect incompatibilities in the manifest. Because there haven't been any official Firefox for Android release in the range [69, 78], we should interpret
browser_specific_settings.gecko.strict_min_versionas version 79 when its value is in the range [69, 78].┆Issue is synchronized with this Jira Task