Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPECIAL_MAJOR logic doesn't work correctly for releases prior to the breakpoint #1428

Open
bhearsum opened this issue Apr 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bhearsum
Copy link
Contributor

We generate the list of major releases in two ways:

  1. Everything before the breakpoint version is considered "old history", and kept unconditionally.
  2. Everything after that is subject to a number of sanity checks

Unfortunately, these sanity checks do not work well with the SPECIAL_MAJOR lists we define elsewhere, leading to any versions in them being ignored as major versions if they are past the breakpoint.

We need to fix this, as 125.0.1 is considered a special major version.

@bhearsum
Copy link
Contributor Author

@gabrielBusta gabrielBusta added the bug Something isn't working label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants