Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix worker threads in Node >=11.10.0 #132

Merged
merged 1 commit into from
Apr 4, 2020
Merged

fix(core): fix worker threads in Node >=11.10.0 #132

merged 1 commit into from
Apr 4, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Apr 3, 2020

Fixes #130.

Follow up on #127.

In worker threads, process.chdir used to be undefined. However since Node 11.10.0 it is now a noop function with a disabled: true property.

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #132 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          162       162           
  Branches        34        34           
=========================================
  Hits           162       162           
Impacted Files Coverage Δ
lib/util/resolveCommand.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76e7bb...10cee06. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work inside workers threads with custom current working directory
2 participants