Thread safety

[FelicePollano]

Hi Damian,
I added thread safety support. There is also a new unit test show it works ( other test still passes ;) )
Please let me know if you like it.
Thanks!

[damianh]

First pull request for the Moq4 line... nice!

Before I pull, I'm going to verify with Daniel what our strategy is with this. Clearly he is thinking about a clean start with Moq5. I'm more interested at this point at getting a Moq4 maintenance release out. There are a couple of things I'd like to do before modifying the existing code base such as getting it running under CI etc.

Leave it with me, will get back to you soon (ish)

[FelicePollano]

Thank you Damian. This is perfectly OK. I will push in the maintenance repo if you/Daniel agree, because I think this is useful ( even in MoQ 5 it would be nice ) Current push is thread safe at the infrastructure level, and this worked for me. I'm just doing an adjustement, that I think is necessary ( and maybe you would consider even in Moq 5) to setup the moq to be SingleThreaded ( in a per method base ) so you can ensure the SUT is calling such a method/property not in multithread ( this is usefule when the actual object isn't thread safe and you want to ensure it is called single threaded )

[kzu]

I guess I missed the notifications here because this was on another repo before :)

I'd make the Moq infrastructure itself thread safe.

[kzu]

Also, the pull requests should go against dev branch (just created it).

[FelicePollano]

Thank you Daniel,
 So you will ignore my push and simply modify the code, correct ?
Anyway well to know, before I push in the only branch there is in the project.I did some other mod in my fork too, have a look if you feel there are useful: http://www.felicepollano.com/2012/03/21/Moq4ThreadSafetyAndMore.aspxMy anglish is bad, I'm sorry in advance for that, but let me know,
Regards,

 

Felice Pollano
Senior IT Architect & Developer

http://www.felicepollano.com

Da: "Daniel Cazzulino" reply@reply.github.com
A: "FelicePollano" felice@felicepollano.com
Cc:
Data: Wed, 21 Mar 2012 10:58:14 -0700
Oggetto: Re: [moq4] Thread safety (#1)

Also, the pull requests should go against dev branch (just created it).

---

Reply to this email directly or view it on GitHub:
#1 (comment)

[kzu]

I think we should separate the previous pull request (just fixing the multi-threading) from the SingleThreaded extension method. (I'm not so sure about the usefulness of that in the "core" moq).

Also, any chance you can keep the tab/spaces on the file intact? it's hard to diff in github site when those are changed. The entire file just appears deleted/added :(

[damianh]

Gents (slightly OT here), when you run the build script / run the unit tests in VS what is your test count?

[FelicePollano]

@danielkzu I will fix this with a new pull, I'm sorry, I wiull check in a private repo to see the proper cr-lf config. For sure the two pull request are separated, the SingleThreaded version maybe is just useful to me, in this case forget about it I will keep it in my private fork :)

[FelicePollano]

@damianh I do use the xUnit external GUI ( I'have not resharper ) anyway My test count is 606 total ( 4 are mine for the mt stuff ) 9 test appear to be skipped. Additionally, there is another test that requires office interop that I have #ifdeffed out on my fork. Hope this help :)

[FelicePollano]

Closing! Fix the CR-LF stuff and work on the proper trunk

[FelicePollano]

Please I'm a bit confused on the crlf stuff: http://help.github.com/line-endings/ My current git settings are AutoCrlLf on and SaveCrLf ON, please tell me the correct ones :)

[kzu]

Should be all false,
On Mar 22, 2012 5:04 AM, "FelicePollano" <
reply@reply.github.com>
wrote:

Please I'm a bit confused on the crlf stuff:
http://help.github.com/line-endings/ My current git settings are
AutoCrlLf on and SaveCrLf ON, please tell me the correct ones :)

---

Reply to this email directly or view it on GitHub:
#1 (comment)

[FelicePollano]

Thank you, I retryed the pull with that settings and should be ok now :) I'm interested in opinion about the SelfThread() expectation. You can point for opinions my post if you want.