DRIVERS-3106 support automatic encryption in unified tests #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
|
lint failure is due to a flaky external URL |
kevinAlbs
reviewed
Feb 13, 2025
source/unified-test-format/tests/valid-pass/poc-queryable-encryption.yml
Show resolved
Hide resolved
source/unified-test-format/tests/valid-pass/poc-queryable-encryption.yml
Outdated
Show resolved
Hide resolved
source/unified-test-format/tests/valid-pass/poc-queryable-encryption.yml
Outdated
Show resolved
Hide resolved
jmikola
reviewed
Feb 19, 2025
source/client-side-encryption/tests/unified/fle2v2-EncryptedFields-vs-EncryptedFieldsMap.yml
Outdated
Show resolved
Hide resolved
source/client-side-encryption/tests/unified/fle2v2-EncryptedFields-vs-EncryptedFieldsMap.yml
Outdated
Show resolved
Hide resolved
mdb-ad
force-pushed
the
unified-test-qe
branch
from
fc37727 to
b1f57f9
Compare
kevinAlbs
reviewed
Feb 28, 2025
source/client-side-encryption/tests/unified/fle2v2-BypassQueryAnalysis.yml
Show resolved
Hide resolved
source/client-side-encryption/tests/unified/fle2v2-BypassQueryAnalysis.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
kevinAlbs
approved these changes
Mar 17, 2025
source/client-side-encryption/tests/unified/fle2v2-BypassQueryAnalysis.yml
Outdated
Show resolved
Hide resolved
jmikola
reviewed
Mar 19, 2025
| [initialData](#initialData). | ||
| - `key_vault_data` can be expressed via [initialData](#initialData) | ||
| - `autoEncryptOpts` will need to be specified when defining a client entity. Preparation of this field may require | ||
| reading AWS credentials from environment variables. |
There was a problem hiding this comment.
It looks like the addition of autoEncryptOpts was the only change introduced in this PR.
Were the other changes not required? If so, why not?
There was a problem hiding this comment.
key_vault_datadoesn't need to be specified as it's equivalent to putting the key documents ininitialData.- Reading AWS variables is already done for
clientEncryptionentities so no extra changes are needed.
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
autoEncryptOptsto client entityencryptedFieldsto collection entityC driver implementation with tests passing: https://spruce.mongodb.com/version/67d1090e4ba7ad0007d78603/