Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6792): use driver version of isUint8Array #4436

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Switch from util/types to ./utils for isUint8Array

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Bundlers need to add a target module for util/types for a method we already implement ourselves. No reason to cause that friction.

Release Highlight

Use isUint8Array defined in the driver rather than util/types

Some users of bundlers for next.js and our very own mongosh noticed a new import from "util/types" that would need to be supported in environments that don't have that module. We already have an internal implementation of isUint8Array so we do not need to add an import for "util/types".

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sorry, something went wrong.

@nbbeeken nbbeeken requested a review from a team as a code owner February 27, 2025 16:07
@baileympearson baileympearson merged commit dfe1fba into main Feb 27, 2025
30 checks passed
@baileympearson baileympearson deleted the NODE-6792-isuint8array branch February 27, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants