Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-6771): sync non-lb-connection-establishment test #4426

Merged
merged 7 commits into from
Feb 24, 2025

Conversation

kevinAlbs
Copy link
Contributor

Description

What is changing?

Sync non-lb-connection-establishment test to mongodb/specifications@d05c33e

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Intended to proactively avoid tests failure once drivers start testing 8.1 builds. See DRIVERS-3108. Drivers are not-yet testing 8.1 (see slack).

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • [ ] Ran npm run check:lint script
  • [ ] Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • [ ] Changes are covered by tests
  • [ ] New TODOs have a related JIRA ticket

Sorry, something went wrong.

@kevinAlbs kevinAlbs marked this pull request as ready for review February 19, 2025 20:25
@kevinAlbs kevinAlbs requested a review from a team as a code owner February 19, 2025 20:25
@baileympearson
Copy link
Contributor

baileympearson commented Feb 20, 2025

evergreen help

Copy link

Available Evergreen Comment Commands

  • evergreen retry - attempts to create a new PR patch; this is useful when something went wrong with automatically creating PR patches
  • evergreen patch - attempts to create a new PR patch; this is required to create a PR patch when only manual PR testing is enabled (use --alias to specify a patch alias)
  • evergreen keep-definitions - reuse the tasks from the previous patch in subsequent patches
  • evergreen reset-definitions - reset the patch tasks to the original definition
  • evergreen refresh - resyncs PR GitHub checks

@baileympearson baileympearson self-assigned this Feb 20, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 20, 2025
@baileympearson
Copy link
Contributor

evergreen retry

@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 21, 2025
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something in here break the coverage task? Seems new but could be an external change

@durran
Copy link
Member

durran commented Feb 24, 2025

Did something in here break the coverage task? Seems new but could be an external change

Looks unrelated but odd it's passing on main. The error is that the assumed role doesn't have permission to list the s3 bucket. I restarted it and it passed.

durran
durran previously approved these changes Feb 24, 2025
@nbbeeken
Copy link
Contributor

Looks unrelated but odd it's passing on main.

@durran I agree, I just wanted to double-check check we looked into it to be sure, ty!

@durran durran merged commit 1a6dc9b into mongodb:main Feb 24, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants