Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(NODE-6755): add tags to benchmarks #4419

Merged
merged 23 commits into from
Feb 24, 2025
Merged

ci(NODE-6755): add tags to benchmarks #4419

merged 23 commits into from
Feb 24, 2025

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Feb 13, 2025

Description

What is changing?

  • Add tags to BenchmarkModule type to facilitate adding tags to benchmarks that get reported when using perf.send
  • Added TAG enum to driver.mts that contains the tags we use across all of our benchmarks for ease of use and to prevent accidental misspellings of tags
  • Added appropriate tags to all benchmark files
  • Added normalized_throughput measurement to all benchmarks
    • For ping, this is calculated as ping_throughput_in_megabytes_per_second/cpuBaseline_throughput_in_megabytes_per_second
    • For all other benchmarks this is calculated as throughput_in_megabytes_per_second/ping_throughput_in_megabytes_per_second
  • Updated driver_bench readme
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sorry, something went wrong.

@W-A-James W-A-James marked this pull request as ready for review February 18, 2025 22:48
@W-A-James W-A-James requested a review from a team as a code owner February 18, 2025 22:48
@nbbeeken nbbeeken self-assigned this Feb 19, 2025
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 19, 2025
@W-A-James W-A-James requested a review from nbbeeken February 19, 2025 20:02
nbbeeken
nbbeeken previously approved these changes Feb 19, 2025
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 19, 2025
@dariakp dariakp self-requested a review February 20, 2025 21:30
@W-A-James W-A-James requested a review from dariakp February 21, 2025 18:54
@W-A-James W-A-James requested a review from nbbeeken February 21, 2025 21:18
nbbeeken
nbbeeken previously approved these changes Feb 21, 2025
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the dead code

Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, CI failures look unrelated, though we should figure out what's happening

@nbbeeken
Copy link
Contributor

The waterfall isn't going to be pretty, but nothing here has caused the red and purple.

@nbbeeken nbbeeken merged commit cb6a7ba into main Feb 24, 2025
19 of 31 checks passed
@nbbeeken nbbeeken deleted the NODE-6755 branch February 24, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants