perf(NODE-6525): remove setPrototype and defineProperty from hot path #4321
+14
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Nov 8, 2024
nbbeeken
commented
Nov 8, 2024
nbbeeken
force-pushed
the
NODE-6525-perf
branch
from
dbd2032 to
a5a8685
Compare
dariakp
reviewed
Nov 8, 2024
addaleax
previously approved these changes
Nov 10, 2024
aditi-khare-mongoDB
added
the
Primary Review
aditi-khare-mongoDB
removed
the
Primary Review
W-A-James
approved these changes
Nov 11, 2024
dariakp
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Regain performance
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript