feat(NODE-6008): deprecate CloseOptions interface #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github.com:mongodb/node-mongodb-native into NODE-5915/refactor-topology-close-to-be-synchronous
aditi-khare-mongoDB
added
the
Primary Review
|
@W-A-James Is the base branch for this PR correct? (CI didn't run because it's not pointing to |
baileympearson
changed the base branch from
NODE-5915/refactor-topology-close-to-be-synchronous
to
main
|
evergreen retry |
I didn't want to mark this as internal until we actually stop using it (once NODE-5915 is merged), so I pointed it at the branch with the changes that remove its usages. |
aditi-khare-mongoDB
previously approved these changes
Mar 11, 2024
aditi-khare-mongoDB
removed
the
Primary Review
nbbeeken
requested changes
Mar 11, 2024
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
aditi-khare-mongoDB
previously approved these changes
Mar 11, 2024
nbbeeken
previously approved these changes
Mar 11, 2024
W-A-James
dismissed stale reviews from nbbeeken and aditi-khare-mongoDB
via
5256536
aditi-khare-mongoDB
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
CloseOptionsinterfaceIs there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-6008
Release Highlight
Deprecated unused
CloseOptionsinterfaceThe
CloseOptionsinterface was unintentionally made public and was only intended for use in the driver's internals. Due to recent refactoring (NODE-5915), this interface is no longer used in the driver. Since it was marked public, out of an abundance of caution we will not be removing it outside of a major version, but we have deprecated it and will be removing it in the next major version.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript