Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(DRIVERS-2812): sdam load balancer tests in serverless #4026

Merged
merged 2 commits into from Mar 7, 2024
Merged

test(DRIVERS-2812): sdam load balancer tests in serverless #4026

merged 2 commits into from Mar 7, 2024

Conversation

durran
Copy link
Member

@durran durran commented Mar 7, 2024 •
edited by aditi-khare-mongoDB

Description

Unskips one load balancer test that was part of the two described in DRIVERS-2812. The other was already running and passing.

What is changing?

  • Unskips the last of the two load balancer tests described in the drivers ticket.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

DRIVERS-2812

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review March 7, 2024 20:28
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Mar 7, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 7, 2024
aditi-khare-mongoDB
aditi-khare-mongoDB approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aditi-khare-mongoDB aditi-khare-mongoDB merged commit 2348548 into main Mar 7, 2024
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Assignees

@durran durran

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
2 participants
@durran @aditi-khare-mongoDB