feat(NODE-4719): Add SDAM Logging Spec #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
requested changes
Dec 7, 2023
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Dec 7, 2023
test/spec/server-discovery-and-monitoring/unified/logging-replicaset.json
Outdated
Show resolved
Hide resolved
aditi-khare-mongoDB
force-pushed
the
NODE-4719/SDAM-logging
branch
from
8b6ae1b
to
61baff7
Compare
nbbeeken
requested changes
Dec 11, 2023
nbbeeken
requested changes
Dec 11, 2023
test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
Show resolved
Hide resolved
nbbeeken
reviewed
Dec 11, 2023
nbbeeken
added
Team Review
nbbeeken
requested changes
Dec 11, 2023
W-A-James
requested changes
Dec 12, 2023
nbbeeken
requested changes
Dec 12, 2023
W-A-James
approved these changes
Dec 13, 2023
nbbeeken
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for logging on SDAM Events, and SDAM spec tests.
What is changing?
All SDAM Events (except serverDescriptionChangedEvent) have a corresponding log. Using the
emitAndLogfunction, we can output their information properly when logging is turned on.Is there new documentation needed for these changes?
Not until logging is released (NODE-5672)
What is the motivation for this change?
To implement standardized logging for SDAM.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript