fix(NODE-5765): change type for countDocuments #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
changed the title
pashok88895
force-pushed
the
bugfix/count_documents
branch
from
ee6c314
to
61c5209
Compare
pashok88895
force-pushed
the
bugfix/count_documents
branch
from
61c5209
to
2fc5296
Compare
alenakhineika
added
tracked-in-jira
dariakp
approved these changes
Nov 28, 2023
alenakhineika
approved these changes
Nov 28, 2023
|
@pashok88895 thank you for contributing! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Is this intentional or just a bug?
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
countDocumentsnow types the filter using the collection SchemaPreviously,
countDocumentshad a weakly typedDocumenttype for the filter allowing any JS object as input. The filter is now typed asFilter<Schema>to enable autocompletion, and, hopefully, catch minor bugs.Thank you to @pashok88895 for contributing to this improvement.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript