-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(NODE-5696): add async-iterator based socket helpers #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+1,292
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Oct 17, 2023
nbbeeken
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@durran I already requested your review since I will be out soon, you might as well take up the primary review reins.
Left thoughts, didn't look at the tests wanted to get you something to spur discussion on some of the decisions.
durran
previously approved these changes
Nov 7, 2023
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
65f6c56
to
6cc1583
Compare
durran
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR is the first connection layer refactor. It does three things
-- read & readMany read wire protocol messages from a connection
-- writeCommand writes a wire protocol message to a connection
These helpers are built on the
readWireProtocolMessages
async generator.readWireProtocolMessages
replaces the message stream - it buffersdata
emissions from the underlying socket until a full wire protocol message has been received.I made some additional refactors but these are intentionally additive. No existing functionality is impacted by the new code paths.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
CSOT requires the ability to cancel socket read & socket write for each operation. A generic socket read/write abstraction will make the CSOT implementation at the connection layer much more straightforward.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript