-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-4849): Add Typescript support for log path in client options #3886
Merged
+146
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8416dee
to
d24e549
Compare
dariakp
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this PR is actually ready for review, so I am moving it back to draft. @aditi-khare-mongoDB Please make sure that any new PR stays in draft until it's actually ready for review.
durran
requested changes
Oct 17, 2023
durran
requested changes
Oct 19, 2023
durran
previously approved these changes
Oct 20, 2023
W-A-James
reviewed
Oct 20, 2023
dariakp
requested changes
Oct 20, 2023
W-A-James
approved these changes
Oct 20, 2023
dariakp
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mongodbLogPath
is now a supported option in client options through connection string or through the MongoClient constructormongodbLogPath
is the path for logging results to be written to.'stdout'
,'stderr'
or a stream of theMongoDBLogWritable
type (any stream with awrite
method).'stdout'
,'stderr'
This feature is currently flagged as internal until Logging is released.
What is changing?
Internally, we can provide a log path to a connection string or to the MongoClient constructor specifying where to output logs.
MongoClient Constructor Example:
ConnectionString Example:
Is there new documentation needed for these changes?
Yes, documentation for
MongoClient
options and connection string options should be updated with updated logging information.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript