Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-5606): use npm 9 on eol node versions #3858

Merged
merged 2 commits into from
Sep 7, 2023
Merged

test(NODE-5606): use npm 9 on eol node versions #3858

merged 2 commits into from
Sep 7, 2023

Conversation

durran
Copy link
Member

@durran durran commented Sep 1, 2023

Description

Fixes Node 16 failures with npm 10.

What is changing?

  • Installs npm@9 when on Node 16 or lower.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5606

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@W-A-James W-A-James self-assigned this Sep 5, 2023
@W-A-James W-A-James self-requested a review September 5, 2023 14:01
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 5, 2023
@durran durran force-pushed the NODE-5606 branch 6 times, most recently from 148d9cd to 5b7cccc Compare September 7, 2023 16:12

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@W-A-James
Copy link
Contributor

Note that test failures are either a result of server changes to how explain documents are returned or known flaky tests

@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 7, 2023
@W-A-James W-A-James merged commit 68e5d67 into main Sep 7, 2023
@W-A-James W-A-James deleted the NODE-5606 branch September 7, 2023 20:12
durran added a commit that referenced this pull request Sep 7, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
durran added a commit that referenced this pull request Sep 7, 2023

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants