-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(NODE-5514): make FLE logic use async-await #3830
Merged
Merged
+385
−723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Aug 21, 2023
7a2b9a9
to
8d961c3
Compare
durran
reviewed
Aug 22, 2023
durran
reviewed
Aug 22, 2023
durran
requested changes
Aug 22, 2023
durran
previously approved these changes
Aug 22, 2023
W-A-James
reviewed
Aug 22, 2023
W-A-James
previously approved these changes
Aug 23, 2023
@baileympearson Can we get the conflict resolved and then good to go. Thanks! |
be9c10d
to
d919d4d
Compare
durran
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
To aid in development and debugging of flaky tests, the internals of our FLE logic is now async-await. The notable exception is
StateMachine.kmsRequest
, which was already manually constructing a promise but is out-of-scope to address now and has a follow up ticket (NODE-3959).Also note: while I did not refactor
kmsRequest
to be async itself, I did refactorsetTLSOptions
to read certificate files asynchronously (in the AC of this ticket).Along the way, I made a few other cleanups. I commented on which refactors I consider optional and am happy to revert them.
mongocryptd
respawn logic into aMongocryptdManager.withRespawn
helperIs there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript