Skip to content

fix(NODE-5548): ensure that tlsCertificateKeyFile maps to cert and key #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 22, 2023
Merged

fix(NODE-5548): ensure that tlsCertificateKeyFile maps to cert and key #3819

merged 11 commits into from
Aug 22, 2023
+57 −6

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Aug 16, 2023 •
edited
Loading

Description

What is changing?

  • file specified by tlsCertificateKeyFile is read into both options.key and options.cert at connect time
  • Updated API docs to reflect this change
Is there new documentation needed for these changes?
  • Updated API docs

What is the motivation for this change?

NODE-5548

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sorry, something went wrong.

addaleax
addaleax reviewed Aug 16, 2023
View reviewed changes
addaleax
addaleax previously approved these changes Aug 16, 2023
View reviewed changes
@W-A-James W-A-James marked this pull request as ready for review August 16, 2023 15:56
@W-A-James W-A-James changed the title fix(NODE-5548): ensure that tlsCertificateKeyFile maps to cert and ke… fix(NODE-5548): ensure that tlsCertificateKeyFile maps to cert and key Aug 16, 2023
@durran durran self-assigned this Aug 17, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 17, 2023
@durran
Copy link
Member

durran commented Aug 17, 2023

https://spruce.mongodb.com/version/64de26af57e85a38c18b68ef/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

durran
durran previously approved these changes Aug 17, 2023
View reviewed changes
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 17, 2023
@durran durran self-requested a review August 17, 2023 15:33
@W-A-James
test(NODE-5548): add failure tests
Loading
Loading status checks…
018d041
@W-A-James W-A-James dismissed stale reviews from durran and addaleax via 018d041 August 17, 2023 18:47
@durran durran added Primary Review In Review with primary reviewer, not yet ready for team's eyes and removed Team Review Needs review from team labels Aug 18, 2023
durran
durran requested changes Aug 18, 2023
View reviewed changes
@W-A-James W-A-James requested a review from durran August 18, 2023 14:18
durran
durran requested changes Aug 21, 2023
View reviewed changes
@W-A-James W-A-James requested a review from durran August 21, 2023 13:54
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 21, 2023
@durran durran merged commit a0955bd into main Aug 22, 2023
@durran durran deleted the NODE-5548 branch August 22, 2023 12:39
@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

@durran durran

@dariakp dariakp

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@W-A-James @durran @addaleax @dariakp