Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-3049): drivers atlas testing #3805

Merged
merged 3 commits into from
Aug 31, 2023
Merged

test(NODE-3049): drivers atlas testing #3805

merged 3 commits into from
Aug 31, 2023

Conversation

durran
Copy link
Member

@durran durran commented Aug 10, 2023 •
edited

Description

This PR makes the necessary changes in the driver for it to be able to be tested by Astrolabe.

What is changing?

  • Adds a new task test:drivers-atlas-testing to run the unified test runner against the Astrolabe tests.
  • Updates the test runner config to use the URI provided by Astrolabe when present in the environment.
  • Creates an astrolabe results write to write the spec defined events.json and results.json
  • Updates the entities map to handle new new entites for iterations, successes, events, failures, and errors.
  • Creates a registry to handle mapping events between the unified client and the entities map.
  • Adds a new unified operation loop, as defined per the Unified Test Format spec

Related drivers-atlas-testing changes: mongodb-labs/drivers-atlas-testing#173

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-3049

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran added the wip label Aug 10, 2023
@durran durran force-pushed the NODE-3049 branch 4 times, most recently from dc00609 to e045f7d Compare August 10, 2023 19:25
@durran durran force-pushed the NODE-3049 branch 7 times, most recently from 6dbbe8d to 4e3a1ba Compare August 24, 2023 14:13
@durran durran force-pushed the NODE-3049 branch 18 times, most recently from 22bf5c2 to 296cf6b Compare August 29, 2023 17:37
@durran durran mentioned this pull request Aug 29, 2023
Merged
@durran durran force-pushed the NODE-3049 branch 2 times, most recently from 3319559 to 4982479 Compare August 29, 2023 18:16
@durran durran removed the wip label Aug 29, 2023
@durran durran force-pushed the NODE-3049 branch 3 times, most recently from d130de3 to c7153dc Compare August 29, 2023 19:44
@durran durran force-pushed the NODE-3049 branch 4 times, most recently from 9235cae to 0069873 Compare August 30, 2023 13:45
@durran durran marked this pull request as ready for review August 30, 2023 13:46
durran
durran commented Aug 30, 2023
View reviewed changes
test/tools/unified-spec-runner/entities.ts

const ENTITY_CTORS = new Map<EntityTypeId, EntityCtor>();
ENTITY_CTORS.set('client', UnifiedMongoClient);
ENTITY_CTORS.set('db', Db);
ENTITY_CTORS.set('clientEncryption', ClientEncryption);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have ClientEncryption in the driver now, I fixed this while I was in the area.

@durran durran force-pushed the NODE-3049 branch 3 times, most recently from beca27e to 1565d35 Compare August 30, 2023 14:47
baileympearson
baileympearson requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, just a few small suggestions

test/tools/runner/config.ts Outdated Show resolved Hide resolved
test/tools/unified-spec-runner/operations.ts Show resolved Hide resolved
test/tools/unified-spec-runner/operations.ts Outdated Show resolved Hide resolved
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 30, 2023
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 30, 2023
@baileympearson baileympearson merged commit 177a4fc into main Aug 31, 2023
22 of 26 checks passed
@baileympearson baileympearson deleted the NODE-3049 branch August 31, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
2 participants
@durran @baileympearson