refactor(NODE-5379): cursor internals to use async-await #3804
+186
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malikj2000
changed the title
nbbeeken
requested changes
Aug 11, 2023
nbbeeken
added
the
Primary Review
nbbeeken
previously approved these changes
Aug 14, 2023
nbbeeken
added
Team Review
baileympearson
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Did we test the changes iin this PR and see if they affect the memory leak reported in NODE-5502?
nbbeeken
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Did we test the changes iin this PR and see if they affect the memory leak reported in NODE-5502?
No, I was hoping you could do that when you were back we ended up needing more context on that in triage anyway, maybe this branch's changes will reveal something further.
nbbeeken
added
Blocked
5 tasks
baileympearson
force-pushed
the
NODE-5379
branch
from
39e7757 to
177a4fc
Compare
nbbeeken
requested changes
Sep 8, 2023
baileympearson
force-pushed
the
NODE-5379
branch
2 times, most recently
from
66526ee to
cb4bb3c
Compare
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
nbbeeken
previously approved these changes
Sep 11, 2023
nbbeeken
added
Team Review
W-A-James
reviewed
Sep 11, 2023
baileympearson
force-pushed
the
NODE-5379
branch
from
de5f961 to
fce1a86
Compare
baileympearson
requested review from
baileympearson,
nbbeeken and
W-A-James
nbbeeken
previously approved these changes
Sep 12, 2023
W-A-James
requested changes
Sep 12, 2023
| @@ -12,7 +12,7 @@ import { | |||
|
|
|||
| const explain = [true, false, 'queryPlanner', 'allPlansExecution', 'executionStats', 'invalid']; | |||
|
|
|||
| describe('CRUD API explain option', function () { | |||
| describe.only('CRUD API explain option', function () { | |||
nbbeeken
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactored cursor internals to use async-await syntax instead of callbacks
What is changing?
getMore, _initialize, cleanupCursor, and [kInit] now use async-await syntax
all classes that inherit from AbstractCursor now use async-await
Is there new documentation needed for these changes?
None
What is the motivation for this change?
further converting the driver to async-await
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript