Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5489): set kerberos compatibility to ^1.0.0 || ^2.0.0 #3803

Merged
merged 3 commits into from Aug 9, 2023

Conversation

durran
Copy link
Member

@durran durran commented Aug 9, 2023

Description

Changes kerberos dependency to ^1.0.0 || ^2.0.0

What is changing?

Changes kerberos dependency back to ^1.0.0 || ^2.0.0 to reintroduce 1.x support.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5489

Release Highlight

Kerberos support for 1.x and 2.x

Moves the kerberos dependency back to ^1.0.0 || ^2.0.0 to indicate support for both 1.x and 2.x. Support for 1.x is removed in 6.0.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran requested a review from nbbeeken August 9, 2023 12:12
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 9, 2023
@nbbeeken nbbeeken self-assigned this Aug 9, 2023
@nbbeeken nbbeeken changed the title feat(NODE-5489): update kerberos dependency fix(NODE-5489): set kerberos compatibility to ^1.0.0 || ^2.0.0 Aug 9, 2023
@nbbeeken nbbeeken merged commit c3b35b3 into 5.x Aug 9, 2023
1 of 3 checks passed
@nbbeeken nbbeeken deleted the NODE-5489-deux branch August 9, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
2 participants