Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5490)!: bump kerberos compatibility to ^2.0.1 #3798

Merged
merged 2 commits into from Aug 8, 2023
Merged

Conversation

durran
Copy link
Member

@durran durran commented Aug 7, 2023

Description

Updates kerberos dependency to ^2.0.1

What is changing?

The optional peer dependency has already changed, this updates the test script to install it instead of the beta. There were no specific tests targeting kerberos 1.x and the filter in the evergreen generation script was removed even though it was no longer actually doing anything.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5490

Release Highlight

Kerberos optional peer dependency minimum version raised to 2.0.1

This was done in 5fcdf93 (#3691)

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp
Copy link
Contributor

dariakp commented Aug 7, 2023

@durran Just a note that the release highlight won't get pulled in by the automation on a non-feat/non-fix commit, so we either have to change this commit type or move the highlight to another breaking change PR; since there was never a feat! corresponding to this change, I think the best thing to do would be to make this commit a feat(NODE-)!: ..., and just point to the commit that actually introduced the change in the PR description.

@durran durran changed the title test(NODE-5490): bump kerberos to 2.0.1 feat(NODE-5490)!: bump kerberos to 2.0.1 Aug 8, 2023
@nbbeeken nbbeeken changed the title feat(NODE-5490)!: bump kerberos to 2.0.1 feat(NODE-5490)!: bump kerberos compatibility to ^2.0.1 Aug 8, 2023
@nbbeeken nbbeeken self-assigned this Aug 8, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 8, 2023
@nbbeeken nbbeeken merged commit 1044be1 into main Aug 8, 2023
19 of 26 checks passed
@nbbeeken nbbeeken deleted the NODE-5490 branch August 8, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
3 participants