Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5376)!: remove deprecated ssl options #3755

Merged
merged 7 commits into from
Jul 10, 2023
Merged

feat(NODE-5376)!: remove deprecated ssl options #3755

merged 7 commits into from
Jul 10, 2023
+47 −157

Conversation

durran
Copy link
Member

@durran durran commented Jul 6, 2023 •
edited
Loading

Description

Removes deprecated SSL options.

What is changing?

Removes:

  • sslCA
  • sslCRL
  • sslCert
  • sslKey
  • sslPass
  • sslValidate
  • tlsCertificateFile

Removes all references in tests, updates related documentation.

Is there new documentation needed for these changes?

Yes - will be noted in the JIRA ticket docs changes.

What is the motivation for this change?

NODE-5376

Release Highlight

Deprecated SSL options have been removed

The following options have been removed with their new counterparts listed after the ->

  • sslCA -> tlsCAFile
  • sslCRL -> crl
  • sslCert -> tlsCertificateKeyFile
  • sslKey -> tlsCertificateKeyFile
  • sslPass -> tlsCertificateKeyFilePassword
  • sslValidate -> tlsAllowInvalidCertificates
  • tlsCertificateFile -> tlsCertificateKeyFile

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sorry, something went wrong.

@durran durran changed the title feat!(NODE-5376): remove deprecated ssl options feat(NODE-5376)!: remove deprecated ssl options Jul 6, 2023
@durran durran marked this pull request as ready for review July 7, 2023 12:40
@nbbeeken nbbeeken self-requested a review July 7, 2023 13:42
@nbbeeken nbbeeken self-assigned this Jul 7, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 7, 2023
nbbeeken
nbbeeken requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few clean ups

@durran durran requested a review from nbbeeken July 9, 2023 22:05
nbbeeken
nbbeeken approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just following up about the highlights

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 10, 2023
@nbbeeken nbbeeken merged commit ee56c8e into main Jul 10, 2023
@nbbeeken nbbeeken deleted the NODE-5376 branch July 10, 2023 18:03
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@durran @nbbeeken