Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5356): prevent scram auth from throwing TypeError if saslprep is not a function #3732

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix(NODE-5356): prevent scram auth from throwing TypeError if saslprep is not a function #3732

merged 3 commits into from
Jun 20, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 16, 2023 •
edited by nbbeeken

Description

What is changing?

Ensures that we only call saslprep if it is a function.

Tests running and passing in CI: https://parsley.mongodb.com/evergreen/mongo_node_driver_rhel80_large_hydrogen_test_latest_server_patch_0e1afc04d0c688857bdcde24c73224fd054ce1b3_6491d422e3c331421344be49_23_06_20_16_30_27/0/task?bookmarks=0,7364&shareLine=593

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the base branch from main to 4.x June 16, 2023 21:55
@baileympearson baileympearson marked this pull request as ready for review June 20, 2023 16:57
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 20, 2023
@nbbeeken nbbeeken self-assigned this Jun 20, 2023
@nbbeeken nbbeeken merged commit 2d028af into 4.x Jun 20, 2023
3 of 5 checks passed
@nbbeeken nbbeeken deleted the NODE-5356 branch June 20, 2023 17:45
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
2 participants
@baileympearson @nbbeeken