Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5316): prevent parallel topology creation in MongoClient.connect #3696

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 1, 2023

Description

What is changing?

Backports the mongo client connect log fix from #3596.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

clemclx and others added 2 commits May 31, 2023 14:55
… topology (#3596)

Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
@baileympearson baileympearson changed the base branch from main to 4.x June 1, 2023 00:40
@baileympearson baileympearson marked this pull request as ready for review June 1, 2023 18:07
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 2, 2023
@nbbeeken nbbeeken self-assigned this Jun 2, 2023
@nbbeeken nbbeeken self-requested a review June 2, 2023 15:52
src/mongo_client.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken merged commit e13038d into 4.x Jun 2, 2023
3 of 5 checks passed
@nbbeeken nbbeeken deleted the NODE-5316 branch June 2, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
3 participants